[Freeciv-Dev] (PR#6947) [Bug] is_at_coast is misleading

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6947 >

For a long time I thought that is_at coast will be TRUE if a tile has 
access to ocean (like you can board a ship from the tile).  However it 
only returns TRUE if the ocean is in a cardinal direction (N,S,E or W) 
from the tile and returns FALSE if there is ocean in, say, NW direction.

I don't see any uses of is_at_coast which rely on this behaviour (maybe
mapgen, it is dubious).  I think is_ocean_near_tile should be renamed
is_at_coast and retired (I like the shorter name).

G.