[Freeciv-Dev] Re: (PR#6585) Delta version 14

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6585 >

On Fri, Nov 21, 2003 at 09:26:41AM -0800, Arnstein Lindgard wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6585 >
> 
> Apply Delta 13 to current cvs.
> 
> 1. Load the attached savegame "bugs_and_gnats.sav.gz".
>    Login as "iuz" with one client, login as "red cloud" with another.
> 
> 2. Move Iuz' destroyer one step SW (numpad 3).
>    Sioux Caravel appears in sight.
> 
> 3. Move destroyer back to where it was.
> 
> 4. Move destroyer one step SW again.
> 
> 5. Caravel is no longer there !

The client removes the enemy unit based on the known state of the
tile. When the servers sends the unit info the second time (step 4)
the delta just removes it. Delta doesn't know that the unit info will
be provide new information to the client since delta doesn't know
about the removal of the unit.

The server will now pass a "goes_out_of_sight=TRUE" to the client in
such cases and delta will know it.

> 6. Quit iuz client (ctrl-Q).
> 
> When you quit, GTK2 client says:
> 
>   (civclient:24121): Gdk-CRITICAL **: file gdkdraw.c:
>   line 495 (gdk_draw_drawable): assertion `src != NULL' failed
> 
> about 30 times.
> 
> GTK1 says:
> 
>   $Gdk-ERROR **: BadPixmap (invalid Pixmap parameter)
>     serial 39879 error_code 4 request_code 56 minor_code 0
>   Gdk-ERROR **: BadDrawable (invalid Pixmap or Window parameter)
>     serial 39880 error_code 9 request_code 62 minor_code 0

This is caused by my attempt to fix a memory leak. I have undo these
changes and create PR#6923 for this issue.

> 7. Restart client and login as "iuz" again.
> 
> Now the server crashes:
> 
>   civserver: packets.c:168: send_packet_data: Assertion
>   `compressed_size < (64*1024-(30*1000))' failed.
>   Aborted

Although I can't reproduce it here this was to be expected. The
compressed size is over >32k. I have added jumbo compressed
packets. We now support upto 4gb compressed packets.

> 8. In addition, when you now quit the clients, they say segfault.

Can you reproduce with the current version?

> If I only connect one client (iuz) to begin with, the server does
> not crash upon reconnect. Weird stuff, uh?
> 

> I hope this bugslayer binge turned massacre allows you to commit
> soon,

Every dead bug is a good bug.

> my next patch already depends upon it :)

Really?! What kind of patch?

Thanks you for your testing.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  The trick is to keep breathing.

delta14.diff.bz2
Description: Binary data