Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2003:
[Freeciv-Dev] Re: (PR#6871) Replace int with Impr_Type_id
Home

[Freeciv-Dev] Re: (PR#6871) Replace int with Impr_Type_id

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: i-freeciv-lists@xxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6871) Replace int with Impr_Type_id
From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 15 Nov 2003 09:40:42 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6871 >

On Sat, Nov 15, 2003 at 09:01:24AM -0800, Raimar Falke wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6871 >
> 
> 
> This patch changes the definition of Impr_Type_id from int to enum
> improvement_type_id. This is coherent with the usage of Impr_Type_id.
> 
> There is a problem of a circular include dependency between
> improvement.h and unittype.h. This could be resolved if we move struct
> impr_effect to effects.h. Is this acceptable?

No it is not. Do not touch this code please. impr_effect is going away
anyway.

-mike




[Prev in Thread] Current Thread [Next in Thread]