[Freeciv-Dev] (PR#6735) Server crashed upgrading a frigate

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6735 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Mon Nov 10 18:47:17 2003]:

> I don't like the idea to add conditions to various code parts.

I agree.

> The
> solution is one unified function. The attached patch implementes this.

I don't like this either, though.  upgrade_unit is a server function and
shouldn't be called from the common code.  Adding a stub to the client
is bad.

> The patch doesn't work like expected in the client case (it should see
> the problem (ship carries units) at the client and not send the
> request to the server) but transported_by is not valid in the client.

What about punit->occupy?  It's the transporter we're worried about
anyway, not the transportee.

jason