[Freeciv-Dev] Re: [FreeCiv-Cvs] rfalke: In case of a conquered city defer the reduct...

[Raimar Falke <i-freeciv-lists@xxxxxxxxxxxxx>]

On Fri, Nov 07, 2003 at 01:58:26PM -0500, Jason Dorje Short wrote:
> freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> >This is an automated notification of a change to freeciv cvs, 
> >on Fri Nov  7 01:45:03 PST 2003 = Fri Nov  7 09:45:03 2003 (GMT)
> >by Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
> >
> >---- Files affected:
> >
> >freeciv/server citytools.c
> >
> >---- Log message:
> >      Tag: HEAD
> >
> >In case of a conquered city defer the reduction of the city size till
> >the city belongs to the new owner.
> >
> >Reported by Gregory Berkolaiko (PR#6544) and Christian Knoke
> >(PR#6754). Patch by Jason Short and me.
> 
> The problem with this, which I may not have made fully clear in the 
> thread, is that now it is the new player's citizens which are being 
> killed rather than the old player's.  This is fundamentally wrong, 
> although it will only matter if there are side effects in city_reduce_size.

I know and I have also considered it. But there are no side effects
now and the previous version was clearly wrong.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  reality.sys corrupt. Reboot Universe? (y,n,q)