[Freeciv-Dev] Re: (PR#6260) Assert in server on city size

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Tue, 23 Sep 2003, Paul Zastoupil wrote:
> 0: Minas Anor is illegal (size24 w9 e1 t0 s20) in cityturn.c line 174
> civserver: shared.c:662: die: Assertion `0' failed.

I cannot reproduce from savegame, but I've seen this from my own autogames
from time to time.

What is consistent about this bug is that we are updating adjacent cities,
then an adjacent cities updates us, and then the bug happens. This
recursiveness is very odd and probably shouldn't be happening. I have a
hard time following this code logic, though.

I think it is linked to PR#1684.

Here is another backtrace, but this one (significantly) asserts on the
first sanity test in auto_arrange_workers() while the one in the previous
post asserted on the last sanity test:

#4  0x08065f98 in real_sanity_check_city (pcity=0x8468418,
    file=0x80e3821 "cityturn.c", line=174) at cityturn.c:157
#5  0x08065fed in auto_arrange_workers (pcity=0x8468418) at cityturn.c:174
#6  0x08065959 in update_city_tile_status (pcity=0x8468418, city_x=4,
city_y=1)
    at citytools.c:2040
#7  0x0806570f in server_set_tile_city (pcity=0x84dd0e0, city_x=13,
    city_y=138839064, type=3221218156) at citytools.c:1968
#8  0x08065934 in update_city_tile_status (pcity=0x84dd0e0, city_x=2,
city_y=4)
    at citytools.c:2055
#9  0x0806570f in server_set_tile_city (pcity=0x8468418, city_x=10,
    city_y=139317472, type=3221218268) at citytools.c:1968
#10 0x0806581a in server_set_worker_city (pcity=0x8468418, city_x=4,
city_y=1)
    at citytools.c:1995
#11 0x08066174 in auto_arrange_workers (pcity=0x8468418) at cityturn.c:243
#12 0x08065959 in update_city_tile_status (pcity=0x8468418, city_x=3,
city_y=0)
    at citytools.c:2040
#13 0x08065886 in update_city_tile_status_map (pcity=0x8468418, map_x=22,
#14 0x080636f1 in transfer_city (ptaker=0x8220ce8, pcity=0x8468418,
    kill_outside=0, transfer_unit_verbose=true, resolve_stack=true,
raze=true)
    at citytools.c:906
#15 0x080643e4 in handle_unit_enter_city (punit=0x87b1d10,
pcity=0x8468418)
    at citytools.c:1297
#16 0x0805edfa in handle_unit_move_consequences (punit=0x87b1d10,
src_x=20,
    src_y=27, dest_x=21, dest_y=28) at unittools.c:2703

These two backtraces might be from two different bugs, though.

  - Per