[Freeciv-Dev] Re: (PR#6189) stacked with ai at start

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Mon, 22 Sep 2003, Jason Short wrote:

> Here's an update of the rewrite to init_new_game().
> 
> 1.  I made the start_pos variable more local, but couldn't remove it 
> entirely.
> 
> 2.  The scenario method of civ placement is highly flawed!!!  But fixing 
> it is a separate issue.
> 
> 3.  Rather than reorder the players, I reorder the starting positions.

While I believe that this patch is correct and you may commit it if you've 
had enough, it's not up to my liking.  I liked the use of start_pos array 
for reordering purposes more.  Now you have to reorder in 2 places whereas 
only one is necessary.  This leads to the strange "swap" function.

G.