[Freeciv-Dev] Re: (PR#6244) advdiplomacy valgrind warning

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Jason Short wrote:

> Not sure what causes this, but it's advdiplomacy.c:928 both times

Some slightly different ones:

==18701== Conditional jump or move depends on uninitialised value(s)
==18701==    at 0x403D16CF: _IO_vfprintf_internal (in /lib/libc-2.3.2.so)
==18701==    by 0x403F01E9: _IO_vsnprintf (in /lib/libc-2.3.2.so)
==18701==    by 0x804C376: my_vsnprintf (support.c:327)
==18701==    by 0x807E091: vnotify_conn_ex (plrhand.c:1052)
==18701==    by 0x807E253: notify_player_ex (plrhand.c:1116)
==18701==    by 0x80C1CA3: notify (advdiplomacy.c:93)
==18701==    by 0x80C25B4: ai_treaty_react (advdiplomacy.c:466)
==18701==    by 0x80C2692: ai_treaty_accepted (advdiplomacy.c:499)
==18701==    by 0x806BB56: handle_diplomacy_accept_treaty (diplhand.c:331)
==18701==    by 0x80C2537: ai_treaty_evaluate (advdiplomacy.c:440)
==18701==    by 0x806C48D: handle_diplomacy_create_clause (diplhand.c:557)
==18701==    by 0x80C29F6: ai_diplomacy_suggest (advdiplomacy.c:623)
==18701==    by 0x80C385E: ai_diplomacy_actions (advdiplomacy.c:1079)
==18701==    by 0x804DC9A: begin_turn (srv_main.c:480)
==18701==    by 0x804F29E: main_loop (srv_main.c:1436)
==18701==    by 0x804FA8E: srv_loop (srv_main.c:1803)
==18701==    by 0x804F512: srv_main (srv_main.c:1590)
==18701==    by 0x804A20F: main (civserver.c:154)
==18701==    by 0x403A04EC: __libc_start_main (in /lib/libc-2.3.2.so)
==18701==    by 0x8049C60: (within /usr/tmp/jshort/freeciv/server/civserver)
==18701==
==18701== Use of uninitialised value of size 4
==18701==    at 0x403D16CF: _IO_vfprintf_internal (in /lib/libc-2.3.2.so)
==18701==    by 0x403F01E9: _IO_vsnprintf (in /lib/libc-2.3.2.so)
==18701==    by 0x804C376: my_vsnprintf (support.c:327)
==18701==    by 0x807E091: vnotify_conn_ex (plrhand.c:1052)
==18701==    by 0x807E253: notify_player_ex (plrhand.c:1116)
==18701==    by 0x80C1CA3: notify (advdiplomacy.c:93)
==18701==    by 0x80C25B4: ai_treaty_react (advdiplomacy.c:466)
==18701==    by 0x80C2692: ai_treaty_accepted (advdiplomacy.c:499)
==18701==    by 0x806BB56: handle_diplomacy_accept_treaty (diplhand.c:331)
==18701==    by 0x80C2537: ai_treaty_evaluate (advdiplomacy.c:440)
==18701==    by 0x806C48D: handle_diplomacy_create_clause (diplhand.c:557)
==18701==    by 0x80C29F6: ai_diplomacy_suggest (advdiplomacy.c:623)
==18701==    by 0x80C385E: ai_diplomacy_actions (advdiplomacy.c:1079)
==18701==    by 0x804DC9A: begin_turn (srv_main.c:480)
==18701==    by 0x804F29E: main_loop (srv_main.c:1436)
==18701==    by 0x804FA8E: srv_loop (srv_main.c:1803)
==18701==    by 0x804F512: srv_main (srv_main.c:1590)
==18701==    by 0x804A20F: main (civserver.c:154)
==18701==    by 0x403A04EC: __libc_start_main (in /lib/libc-2.3.2.so)
==18701==    by 0x8049C60: (within /usr/tmp/jshort/freeciv/server/civserver)

It makes little sense to me.

jason