Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2003:
[Freeciv-Dev] Re: Make gen2 fair (PR#4659)
Home

[Freeciv-Dev] Re: Make gen2 fair (PR#4659)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rt-guest@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Make gen2 fair (PR#4659)
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Wed, 17 Sep 2003 09:41:13 -0700
Reply-to: rt@xxxxxxxxxxxxxx

Concerning the comment, the function headers should be like this:
/********************************************
  blah
*********************************************/
but it's not said explicitly, so if you want to make a patch to 
CodingStyle, go ahead.

But I was mostly fixing "if(blah)" to "if (blah)" and such.

I still don't like the result very much:
1. "done" should be a bool
2. the while loop can go on forever (theoretically)
3. the comment still says "returns zero if successfull"
4. you don't need to check (smth == FALSE), but rather (!smth).

2 is the most serious I guess.

G.




[Prev in Thread] Current Thread [Next in Thread]