[Freeciv-Dev] Re: (PR#6094) Assert in PF.

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Mon, 15 Sep 2003, Jason Short wrote:

> Per I. Mathisen wrote:
> > On Mon, 15 Sep 2003, Gregory Berkolaiko wrote:
> > 
> >>>2.You do calculations assuming a unit gets move_rate MP per turn, then
> >>>finagle things at the end so less-than-zero values work out.I think
> >>>the calculations should just account for the initial MP to begin with,
> >>>although this does take more code changes.
> >>
> >>I don't see what you mean.With the changes the code correctly deals with
> >>the case when initial MPs are bigger than move_rate.What else need to be
> >>done?
> 
> For the bulk of the calculations you assume that inital MP==move_rate. 
> Then at the end some extra calculations are done that fix any off-by-one 
> errors that may result.  This just doesn't seem right...

I still don't know what causes your unhappiness.  Can you point me to the 
places which you would like to see changed?  Alternatively, provide your 
own patch.

> > 1. Under the alternating movement model, units for all but one player will
> > start the turn with zero moves.
> > 
> > 2. Units with zero moves total may exist some day.

These have no relevance to the present discussion, I feel.

G.