[Freeciv-Dev] (PR#6094) Assert in PF.

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Mon, 15 Sep 2003, Jason Short wrote:

> Gregory Berkolaiko wrote:
> > Is anyone going to commit my PF fix to 6094?
> > Jason?  Raimar?
> 
> I'm not sure this is the correct fix.
> 
> 1.  You say (in a comment) that it is a bug for units to have more MP 
> than their move_rate.  I don't think I agree.

Well, it's just a comment.

> 2.  You do calculations assuming a unit gets move_rate MP per turn, then 
> finagle things at the end so less-than-zero values work out.  I think 
> the calculations should just account for the initial MP to begin with, 
> although this does take more code changes.

I don't see what you mean.  With the changes the code correctly deals with 
the case when initial MPs are bigger than move_rate.  What else need to be 
done?

I have to assume units get some # of MPs per turn, don't you think?

G.