[Freeciv-Dev] Re: (PR#5252) Wishlist: Defined civil war nations

["Morgan Jones" <morgan.jones@xxxxxxxxxxxxxxx>]

> Here's some. I've got nearly every nation, though some of them are
> uite stretched. I figured it'd be better to pick small neighboring
> nations than totally random ones (e.g. korea, which AFAIK has never
> had a breakaway state, gets japan, which is a whole lot better than
> getting france). I've stuck to history whenever possible.
> 
> BTW: patch looks great, except for the minor coding issues mentioned
> elsewhere (-1 vs NO_NATION etc.) I wouldn't worry about efficientcy,
> there's no way this code is going to become a bottleneck,
> 
> --Daniel
> 
Well done, you bet me to it!  I was having difficulty getting diff to
work properly.

I had a quick scan through the patch and it looks like we made similar
choices in most places, so I won't bother posting my patch.

     -Morgan