[Freeciv-Dev] Re: (PR#5568) add I_DEMOLISHED Impr_Status

["Ben Webb" <ben@xxxxxxxxxxx>]

On Sun, Aug 31, 2003 at 03:51:03AM -0700, Per I. Mathisen wrote:
> On Fri, 29 Aug 2003, Mike Kaufman wrote:
> > The problem comes on city destruction. What happens if a building confers a
> > global effect that survives and then its city is destroyed. We still want
> > that effect active (Apollo and Manhattan are examples). Where is the effect
> > stored in a savegame? Currently we have a destroyed_wonders field which can
> > be transformed into a global_improvements field: a array of B_LAST elements
> > that counts the total number of improvments for everybody. But we would
> > also need such an array for each player (Player range) and each island
> > (Island range). Unless we restrict .survives in some way, I don't see
> > another way.
> I dislike the idea of free-floating effects. Effects should IMHO be
> grounded in a game basic element like global, city, unit, player or
> government. An island is not a game basic element, it is a data property,
> and therefore to assign an effect to an island seems wrong to me.

Point of information: impr-gen does not support island-range surviving
effects - only player and global range. It does this in just the way
Mike is suggesting (although the list is a boolean, not a count -
while it may be interesting to do the latter, this is of academic
interest only while surviving effects are restricted to Wonders).

        Ben
-- 
ben@xxxxxxxxxxx                      http://salilab.org/~ben/
"Ice formed on the butler's upper slopes."
        - 'Pigs Have Wings (1952), ch. 5, pt. i', P.G. Wodehouse