Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2003:
[Freeciv-Dev] (PR#5431) Unecessary Global Variable in mapgen.c 		Home

[Freeciv-Dev] (PR#5431) Unecessary Global Variable in mapgen.c

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#5431) Unecessary Global Variable in mapgen.c
From: "Cameron Morland" <cameron@xxxxxxxxxx>
Date: Thu, 28 Aug 2003 10:08:59 -0700
Reply-to: rt@xxxxxxxxxxxxxx 
[glip - Thu Aug 28 13:08:55 2003]:
 
> The code is produced by good intentions, if you look down to see how 
> totalweight is used.  But I agree it should be removed.  The same, 
> however, should be done to the similar code in mapgenerator4, in the 
> same patch!

This patch doesn't use static variables, and fixes the incredibly ugly
code in gen4. This single line will do exactly the same thing as what
was there before, and is vastly more transparent to what it's doing.

I am fairly certain my arithmetic is correct.

Attachment: mapgentotalweight2.diff
Description: mapgentotalweight2.diff

[Prev in Thread] Current Thread [Next in Thread]