[Freeciv-Dev] Re: (PR#2943) New Flush code

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

Rafa³ Bursig via RT wrote:

> This is new client Flush code.

I'm really not sure that this is the right way to go.

But in any case, you also need to flush before and during any animation, 
otherwise the screen can be non-updated during this time.  At any rate, 
the GTK client doesn't draw animation correctly (with fog); this may be 
a symptom of a deeper bug (in the original drawing code).

Also, it seems that seting the max number of rects to a lower number 
(than 80) is probably more efficient.  We could update 79 individual 
rectangles, but redrawing the entire screen will be far faster.  10 
seems more reasonable - although this is certainly a value that can be 
tweaked to optimize performance (if such is necessary).

Another problem is that in most GUIs the city names are drawn "directly 
to the display" (of course there is an additinal level of buffering 
"invisibly" provided by the library).  This means if the flush happens 
at an inopportune moment it can overwrite the city name.  The solution 
is that all GUIs should buffer the city names (like gui-sdl does now).

jason