[Freeciv-Dev] (PR#2948) civclient assertion error in unittype.c

["Guest via RT" <rt@xxxxxxxxxxxxxx>]

I've had two of these errors lately.  Unfortunately, I could NOT
reproduce them by loading the savegame from the previous turn.  Both
errors occurred when inciting a revolt in an enemy city.  The city box
would come up blank, and after a few seconds I'd get the error:

> civclient: unittype.c:86: get_unit_type: Assertion `id >= 0 && id <
200 && id
< game.num_unit_types' failed.

A savegame is available at
http://kenn-michelle.ca:8080/freeciv/crash1.sav.gz.  I incited the
revolt in Beit-Shemesh.  A core file (8 MB) is at
http://kenn-michelle.ca:8080/freeciv/core.gz.  Here is the backtrace:

(gdb) bt
#0  0x42028cc1 in kill () from /lib/i686/libc.so.6
#1  0x42028ac8 in raise () from /lib/i686/libc.so.6
#2  0x4202a019 in abort () from /lib/i686/libc.so.6
#3  0x42021cd6 in __assert_fail () from /lib/i686/libc.so.6
#4  0x080c17cd in get_unit_type () at unittype.c:88
#5  0x08078a1a in fill_unit_sprite_array (sprs=0xbffff614, punit=0xa10f060,
    solid_bg=0x0) at tilespec.c:1294
#6  0x0809834a in put_unit_gpixmap (punit=0xa10f060, p=0xa197228)
    at mapview.c:1105
#7  0x0807f6eb in city_dialog_update_supported_units (pdialog=0xa2560e8)
    at citydlg.c:2023
#8  0x0807b773 in refresh_city_dialog (pcity=0x8f3a168) at citydlg.c:416
#9  0x08066070 in client_remove_unit (punit=0xa10f060) at climisc.c:102
#10 0x08065603 in handle_packet_input (packet=0xa2732e0, type=0)
    at civclient.c:319
#11 0x08068326 in input_from_server (fd=4) at clinet.c:329
#12 0x40284bf2 in gdk_io_invoke () from /usr/lib/libgdk-x11-2.0.so.0
#13 0x403e142f in g_io_unix_dispatch () from /usr/lib/libglib-2.0.so.0
#14 0x403bff65 in g_main_dispatch () from /usr/lib/libglib-2.0.so.0
#15 0x403c0f98 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#16 0x403c12ad in g_main_context_iterate () from /usr/lib/libglib-2.0.so.0
#17 0x403c1a1f in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#18 0x400f439f in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#19 0x08090e12 in ui_main (argc=1, argv=0xbffffa14) at gui_main.c:1086
#20 0x08065106 in main (argc=1, argv=0xbffffa14) at civclient.c:240
#21 0x420158d4 in __libc_start_main () from /lib/i686/libc.so.6

On both occasions, when I loaded the savegame later and incited the
revolt (without error), I saw "Game: Teleported your
<Musketeers/Knights> from (x,y) to <city>".  Perhaps the error had
something to do with the teleporting?

I'm using gtk2 client from Jan 24 CVS on Red Hat 8.

Kenn