[Freeciv-Dev] Re: (PR#2608) replace key_move_xxx with key_unit_move

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

rwetmore@xxxxxxxxxxxx via RT wrote:
> There is still the problem that you convert from a gui_dir to ... a gui_dir.

It converts from a direction8 to a direction8.

> You should use different enum direction values to keep track of when you
> are using one direction model (GUI) and the other (MAP) otherwise the
> conversions don't make a whole lot of sense to the uninitiated. And maybe
> moreso you can't tell from the code when you have done a conversion or are
> using converted values unless you track back through the entire flow path.
> If one uses DIR8_NORTH it should be clear which direction one is talking
> about, i.e. GUI or MAP.

As I've said before, I don't think we need to or should add a new enum 
for each 'type' of direction.  They all use the same underlying type, 
just like all types of coordinate systems all use integers.  Does anyone 
else have an opinion on this?

jason