[Freeciv-Dev] Re: (PR#1883) Client is not full aware of game end

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

On Tue, 2003-01-07 at 10:51, Raimar Falke via RT wrote:
> On Wed, Jan 01, 2003 at 04:17:51AM -0800, Jason Short via RT wrote:
> > > But even if I have started to make the client aware of the game end if
> > > you consider that you can open a dialog *BEFORE* the game end and have
> > > it still open *AFTER* the game end, then we need a function to popdown
> > > all the dialogs or at least all the possible wrong dialogs when the
> > > status changes, for thi reason PR#533 was related to this one.
> > 
> > popdown_all_game_dialogs is a nice concept, but unreliable.  Only the
> > gtk2 client gets all game dialogs, other GUIs have no means of tracking
> > them all (consider the goto_notify dialogs).  But it seems to me that
> 
> Why not? popdown_all_game_dialogs should do what it name says on all
> GUIs.

It *should*, but not all game dialogs are tracked; it's hard to get them
all.

The GTK2 client queries GTK for a list of open windows and closes
those.  In other clients we just call various functions to close various
windows.  None of these close notify goto dialogs, for instance.

But, none of this is really an issue.  Both of these patches aim to fix
the problem, and both provide other good benefits as well.  So using
both is not a problem.

jason