[Freeciv-Dev] (PR#2745) Change style guide to favor a++ instead of ++a

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

$ grep -Irn '[a-nA-Z][+][+]' .|fgrep .c|wc -l
   1961
$ grep -Irn '[+][+][a-nA-Z]' .|fgrep .c|wc -l
    132

From these 132 cases some are in intl/ (out of reach), some are
required:
  ./client/gui-sdl/gui_dither.c:516:      if (++h >= NORMAL_TILE_HEIGHT / 2) {
  ./server/mapgen.c:1888:  && ++j < 500) {
but the larger part doesn't require it. for loops like
  ./client/gui-sdl/optiondlg.c:347:  for (i = 0; pModes[i]; ++i) {
can be replaced. And simple statements like:
  ./client/gui-mui/messagedlg.c:111:          ++err;
  ./common/rand.c:208:      ++behaviourchange;
  ./server/unithand.c:187:            ++number_of_upgraded_units;
also doesn't need it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  The trick is to keep breathing.