Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2003:
[Freeciv-Dev] (PR#277) citizens not displayed in the xaw client
Home

[Freeciv-Dev] (PR#277) citizens not displayed in the xaw client

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: thue105@xxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#277) citizens not displayed in the xaw client
From: "Jason Short via RT" <rt@xxxxxxxxxxxxxx>
Date: Tue, 7 Jan 2003 01:43:22 -0800
Reply-to: rt@xxxxxxxxxxxxxx

[thue105@xxxxxxxxxxxxxxxxxx - Sun Feb 27 21:30:15 2000]:

> If you have more than [50] citizens in a city only the first [50] are
> displayed in the [xaw] client.

It looks to me like fixing this for XAW is as simple as removing the
limit (see attached patch).  But I don't have a savegame with a large
city (> 50 citizens) to test it on.  Can anyone provide such a game?

jason

Index: client/gui-xaw/citydlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-xaw/citydlg.c,v
retrieving revision 1.87
diff -u -r1.87 citydlg.c
--- client/gui-xaw/citydlg.c    2003/01/05 15:34:06     1.87
+++ client/gui-xaw/citydlg.c    2003/01/07 09:42:30
@@ -72,7 +72,6 @@
 #include "cityicon.ico"
 
 #define MIN_NUM_CITIZENS       22
-#define MAX_NUM_CITIZENS       50
 #define DEFAULT_NUM_CITIZENS   38
 #define MIN_NUM_UNITS          8
 #define MAX_NUM_UNITS          20
@@ -872,8 +871,6 @@
       pdialog->num_citizens_shown=widthTotal/itemWidth;
       if (pdialog->num_citizens_shown<MIN_NUM_CITIZENS)
        pdialog->num_citizens_shown=MIN_NUM_CITIZENS;
-      else if (pdialog->num_citizens_shown>MAX_NUM_CITIZENS)
-       pdialog->num_citizens_shown=MAX_NUM_CITIZENS;
     } else {
       pdialog->num_citizens_shown=MIN_NUM_CITIZENS;
     }

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#277) citizens not displayed in the xaw client, Jason Short via RT <=