Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2003:
[Freeciv-Dev] (PR#2403) Popup items with slash won't translate
Home

[Freeciv-Dev] (PR#2403) Popup items with slash won't translate

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: juhani.heino@xxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#2403) Popup items with slash won't translate
From: "Jason Short via RT" <rt@xxxxxxxxxxxxxx>
Date: Sat, 4 Jan 2003 04:01:49 -0800
Reply-to: rt@xxxxxxxxxxxxxx

[jdorje - Fri Dec 20 09:28:37 2002]:

> The bug is in translate_menu_path in gui-gtk-2.0/menu.c:798.  It does
> not respect \/ as a genuine slash and instead tries to split the
> string
> around it.  Thus it tris to translate "Go" and "Airlift to city", both
> of which fail.

I recommend the attached patch (the same as was originally submitted)
for 1.14.0.  This will change a translatable string, but since the
original never translated to begin with this is okay.  However,
translators should be given the opportunity to translate the new string.

It's probably best to apply this to cvs HEAD also, unless/until the bug
is fixed.

jason

Index: client/gui-gtk-2.0/menu.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/menu.c,v
retrieving revision 1.10
diff -u -r1.10 menu.c
--- client/gui-gtk-2.0/menu.c   2003/01/01 11:51:33     1.10
+++ client/gui-gtk-2.0/menu.c   2003/01/04 11:58:02
@@ -695,13 +695,13 @@
        orders_menu_callback,   MENU_ORDER_PATROL                               
        },
   { "/" N_("Orders") "/" N_("_Go to"),                 "g",
        orders_menu_callback,   MENU_ORDER_GOTO                                 
        },
-  { "/" N_("Orders") "/" N_("Go\\/Airlift to City"),   "l",
+  { "/" N_("Orders") "/" N_("Go or Airlift to City"),  "l",
        orders_menu_callback,   MENU_ORDER_GOTO_CITY                            
        },
   { "/" N_("Orders") "/sep4",                          NULL,
        NULL,                   0,                                      
"<Separator>"   },
   { "/" N_("Orders") "/" N_("Disband Unit"),           "<shift>d",
        orders_menu_callback,   MENU_ORDER_DISBAND                              
        },
-  { "/" N_("Orders") "/" N_("Diplomat\\/Spy Actions"), "d",
+  { "/" N_("Orders") "/" N_("Diplomat and Spy Actions"),       "d",
        orders_menu_callback,   MENU_ORDER_DIPLOMAT_DLG                         
        },
   { "/" N_("Orders") "/" N_("Explode Nuclear"),        "<shift>n",
        orders_menu_callback,   MENU_ORDER_NUKE                                 
        },

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#2403) Popup items with slash won't translate, Jason Short via RT <=