[Freeciv-Dev] (PR#2578) GTK client crash in inputdlg

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

While trying out some new code with Vasco I ran across this crash using
an unpatched GTK client.  It is reproducable.

Open a city dialog, go to CMA panel.  "Add new preset".  Then close the
city dialog.  Now enter the preset name.

#0  0x080d2427 in cma_is_city_under_agent (pcity=0x0,
parameter=0xbfffec50) at cma_core.c:1988
1988      if (!cma_get_parameter(ATTR_CITY_CMA_PARAMETER, pcity->id,
&my_parameter)) {
(gdb) bt
#0  0x080d2427 in cma_is_city_under_agent (pcity=0x0,
parameter=0xbfffec50) at cma_core.c:1988
#1  0x080d4fa5 in cmafec_get_fe_parameter (pcity=0x0, dest=0xbfffecc0)
at cma_fec.c:116
#2  0x08088ab2 in cma_preset_add_callback_yes (input=0x8324018 "main",
data=0x83950b0) at cma_fe.c:493
#3  0x0809aaa3 in input_dialog_ok_callback (w=0x83922c0, data=0x83b0e10)
at inputdlg.c:65
#4  0x400e44d6 in gtk_marshal_NONE__NONE () from
/usr/lib/libgtk-1.2.so.0

jason