[Freeciv-Dev] Re: (PR#2486) Civ 2 Style Waste

["Raahul Kumar via RT" <rt@xxxxxxxxxxxxxx>]

--- Davide Pagnin via RT <rt@xxxxxxxxxxxxxx> wrote:
> This patch adds some new modifiers to the default ruleset, that work the
> same way as corruption params do. 
> > 
> > waste_modifier             
> > waste_fixed_distance       
> > waste_distance_factor       
> > waste_extra_distance        
> >  
> > Synced Civ 2 style Waste implementation to current CVS. A few notes about
> > this patch:
> > 
> > I have not updated Civ 1/2 rulesets to use waste. If this patch is
> committed I will send in modified rulesets.
> 
> Civ 1 has not knowledge of waste, thus don't need to be updated, anyway.
> 
> As for civ2 settings, I have made complete testing of them, and I can
> supply them. (Or we can cross-check them if you prefer)

I need to add these 4 lines to Civ 1 ruleset setting them all to 0.

waste_modifier         = 0  
waste_fixed_distance   = 0    
waste_distance_factor  = 0     
waste_extra_distance   = 0     

Supply those Civ 2 waste params if you will.

> > Only gui-gtk has support in the city dialog for showing waste. All other
> guis have no support. Waste still happens, but the player can't see how it is
> > occuring.  
> > 
> > Please review/commit.
> 
> I definitely think that you need to add a mandatory capability string to
> the server, to cope with this change.
> 
> Have you tried what happen if a non-patched client connects to a patched
> server and tries to use CMA?
> 
> What happen if a patched client connect to a non-patched server?

The answer is no, and I intuit bad things happen to a non patched
client/patched server. Mandatory string "WASTE" will be added. No real
bugs happen in the patched client/unpatched server.

Where do I go look for docu on how to add mandatory strings by the way?
I have not done it before. 

Aloha,
RK.

But in our enthusiasm, we could not resist a radical overhaul of the system, in

which all of its major weaknesses have been exposed, analyzed, 
and replaced with new weaknesses. -Bruce Leverett, "Register Allocation in
Optimizing Compilers" 



__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com