Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2002:
[Freeciv-Dev] Re: (PR#2439) city iterator cleanup
Home

[Freeciv-Dev] Re: (PR#2439) city iterator cleanup

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2439) city iterator cleanup
From: "Gregory Berkolaiko via RT" <rt@xxxxxxxxxxxxxx>
Date: Fri, 29 Nov 2002 05:07:06 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Thu, 28 Nov 2002, Jason Short via RT wrote:

> This patch was suggested by Per:
> 
> It removes city_radius_iterate.  This macro is not used, probably
> shouldn't ever be used, and cannot be used because there is no
> city_radius_iterate_end.
> 
> It redefines map_city_radius_iterate to use city_map_checked_iterate.  I
> also change the parameter names, and add a comment on this iterator.

Good patch.  I love removing obsolete code.

I was going to commit it and then I looked at how it's done and discovered 
that CITY_MAP_SIZE is a fake define and is hardcoded.  So I couldn't fight 
off the temptation to add some comments on that.  And also correct some 
mistakes...  And comment formatting.  Please check my English and 
commit...

G.




[Prev in Thread] Current Thread [Next in Thread]