[Freeciv-Dev] Re: GTK+ client memory leaks

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Wed, Nov 27, 2002 at 01:59:14AM +0000, Vasco Alexandre Da Silva Costa wrote:
> 
> Howdy,
> 
> I found a whole heap of memory leaks in the GTK+ client produced by
> spurious use of the intl_slist() function and "forgetting" to free the
> memory afterwards. This affects the city dialog and a bunch of other places.
> 
> Such mallocing is unwarranted in the first place so I recomend we replace
> that most troublesome function with this one:
> 
> void intl_slist(int n, const char **s, bool *done)
> {
>   int i;
> 
>   if (!*done) {
>     for(i=0; i<n; i++) {
>       s[i] = _(s[i]);

There is no guarantee that strlen(_(s[i])) <= strlen(s[i]).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "That's fundamental game play!  My main enemy is *ALWAYS* fighting 
  a 4-front war.  I make sure of it!"
    -- Tony Stuckey, freeciv-dev