[Freeciv-Dev] Re: (PR#1328) [patch] "turns-to-grow" on the map overview

["Vasco Alexandre Da Silva Costa via RT" <rt@xxxxxxxxxxxxxx>]

On Sun, 17 Nov 2002, Raimar Falke via RT wrote:

> On Sat, Nov 16, 2002 at 08:28:15AM -0800, Raimar Falke via RT wrote:
> > On Tue, Nov 05, 2002 at 06:51:52PM -0800, Jason Short via RT wrote:
> > >
> > > Attached is an update of this patch.
> > >
> > > Changes:
> > > - Updated for current CVS.
> > > - GTK2 support.  This is lacking because it doesn't use colors the way
> > > the other clients do.  I'm not familiar with Pango (yet).
> >
> > IMHO this just screams for a unification in some *_common file.
>
> And the patch. GTK and XAW is tested. GTK2 still needs convertion and
> testing.

The GTK+ font code at least has issues. You should use the string extents
function instead of checking the font data directly. Not all languages are
the same. What works for the Latin alphabet may not work elsewhere and
this is why the string extents functions exist in the first place.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa