[Freeciv-Dev] Re: (PR#2314) Changing tech lose bulbs after load

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Sat, Nov 16, 2002 at 04:43:40PM -0800, Jason Short via RT wrote:
> 
> [kauf - Tue Nov 12 15:29:27 2002]:
> 
> > > When getting new tech, save game and restart saved game,
> > > and changing the tech in the same turn, all bulbs are lost.
> > 
> > that's because research.bulbs_researched_before is not currently saved in
> > a savegame. Should be fixed, but I don't know if it's that critical for
> > 1.14.0.
> 
> Actually, it turns out it's because got_tech isn't saved.
> 
> research.bulbs_researched_before is used in conjunction with
> research.changed_from so that if you change your tech target, then
> change it back in the same turn, you don't lose your bulbs.  (Thanks to
> Davide for pointing this out.)
> 
> This patch saves all three values.  It should therefore fix both bugs.

> P.S.  IMO got_tech should be stored in the research struct as well. This
> is reflected in my naming of the save-file entry. 

I agree.

> And why is it updated in cityturn.c?  Questions for another day...

Because it has to be reset each turn.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We just typed make..."
    -- Stephen Lambrigh, Director of Server Product Marketing at Informix,
                         about porting their Database to Linux