[Freeciv-Dev] Re: (PR#2350) Remove dependencies
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Mike Kaufman via RT wrote:
> I don't like this change. It adds files to common/, it adds an extra layer
> of indirection to header files, simply to improve compilation time if a
> certain file is changed?? Hmm.
The addition of a file or two seems OK, but this sets a bad precedent:
one file per iterator. Since there are more iterators that should be
implemented, does this mean each of them should get its own files?
Such a change would be fine with me if it moved all iterators into a
single file.
jason
|
|