[Freeciv-Dev] Re: (PR#2319) hot swap sound plugin

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

Per I. Mathisen via RT wrote:

> Attached is a follow-up to this which implements hot swap of sound plugins
> from within the freeciv client. Just change plugin in the local options
> dialog and voila! new sound plugin for you.

Three problems:

1.  audio_select_plugin will exit if an invalid plugin is given.  It is 
easy to give an invalid plugin name (the GtkCombo lets you type in 
text).  Obviously this needs to be checked - but the current behavior of 
exiting should probably still be preserved when you start a game.  But 
what if a player saves "x" as their default sound plugin?

2. It would make sense for the option callback function to return a 
boolean indicating whether the choice was acceptable.  Without that, it 
is also possible to choose the same plugin again (choose "x" which gets 
ignored, then choose the plugin you just had).  I'm not sure that 
audio_select_plugin will handle that correctly either (it calls init on 
an already-initialized plugin).

3.  The text for the option should be changed from "Default sound 
plugin" to indicate that the change will take place immediately. 
Probably just "Sound plugin" will do.  Or you could make it a separate 
option (so that the current plugin and default plugin were saved 
independently), although I see no advantage in this.

jason