Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2002:
[Freeciv-Dev] Re: (PR#2269) PNG for gui-stub
Home

[Freeciv-Dev] Re: (PR#2269) PNG for gui-stub

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2269) PNG for gui-stub
From: "Jason Short via RT" <rt@xxxxxxxxxxxxxx>
Date: Thu, 7 Nov 2002 11:42:58 -0800
Reply-to: rt@xxxxxxxxxxxxxx

This patch updates gui-stub by changing gfx_fileextension to have PNG be 
the only graphics extension listed.

Although a small change, this is perhaps symbolic of the transition from 
XPM to PNG.  If we stick with the paradigm that one format must be 
standard, then this function (in the stub files) should have only one 
entry.  GUIs may be able to accept other formats (XPM is still used for 
backwards-compatability in many places), but is not strictly required.

Is this acceptable?  Should XPM be recommended for all GUIs to provide 
more backwards-compatability?

jason

? client/gui-stub/stub-update.diff
Index: client/gui-stub/graphics.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-stub/graphics.c,v
retrieving revision 1.7
diff -u -r1.7 graphics.c
--- client/gui-stub/graphics.c  7 Nov 2002 19:36:28 -0000       1.7
+++ client/gui-stub/graphics.c  7 Nov 2002 19:39:19 -0000
@@ -36,6 +36,11 @@
        /* PORTME */
 }
 
+/**************************************************************************
+  Return a NULL-terminated, permanently allocated array of possible
+  graphics types extensions.  Extensions listed first will be checked
+  first.
+**************************************************************************/
 const char **
 gfx_fileextensions(void)
 {
@@ -44,7 +49,7 @@
   /* hack to allow stub to run */
   static const char *ext[] =
   {
-    "xpm",
+    "png",
     NULL
   };
 

[Prev in Thread] Current Thread [Next in Thread]