Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2002:
[Freeciv-Dev] (PR#2262) [Bug][Patch] Really call put_conv
Home

[Freeciv-Dev] (PR#2262) [Bug][Patch] Really call put_conv

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#2262) [Bug][Patch] Really call put_conv
From: "Vasco Alexandre da Silva Costa via RT" <rt@xxxxxxxxxxxxxx>
Date: Sun, 3 Nov 2002 09:59:18 -0800
Reply-to: rt@xxxxxxxxxxxxxx

[rfalke - Mon Oct 28 20:06:59 2002]:

>   if (put_conv_callback) {
>     size_t buffer_length;
>     unsigned char *buffer = put_conv_callback(value, &buffer_length);
> 
>     dio_put_memory(dout, buffer, buffer_length);
>     free(buffer);
>   } else {
>     dio_put_memory(dout, value, strlen(value) + 1);
>   }

You are not checking for a NULL return value from put_conv_callback.
I'll commit the patch with the fix today.



[Prev in Thread] Current Thread [Next in Thread]