Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2002:
[Freeciv-Dev] Re: request for discussion: hiding enums using typedef
Home

[Freeciv-Dev] Re: request for discussion: hiding enums using typedef

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Per I. Mathisen" <per@xxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: request for discussion: hiding enums using typedef
From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Wed, 16 Oct 2002 22:28:58 +0200

On Tue, Oct 15, 2002 at 09:58:19PM +0000, Per I. Mathisen wrote:
> This patch un-hides the enums that are hidden through typedef in
> improvement.h as part of the generalised improvements patches.
> 
> I think hiding enum types in this way is bad, since those reading this
> part of the code get less information about what it is. It makes
> understanding what goes on harder.

1) all enums have lower case name. Capitalized names are for typedefs.
2) What about Impr_Status? Will it be converted to an enum? If yes
will you also search & replace?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  reality.sys corrupt. Reboot Universe? (y,n,q)


[Prev in Thread] Current Thread [Next in Thread]