Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2002:
[Freeciv-Dev] Re: [FreeCiv-Cvs] jdorje: S1_14 BRANCH: In the diplomacy d
Home

[Freeciv-Dev] Re: [FreeCiv-Cvs] jdorje: S1_14 BRANCH: In the diplomacy d

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: Freeciv Maintainers <developers@xxxxxxxxxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [FreeCiv-Cvs] jdorje: S1_14 BRANCH: In the diplomacy dialog, if th...
From: Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 15 Oct 2002 06:25:32 -0500

My mistake: this patch changes the translatable strings by adding the string "more". Even worse, it seems to get a fuzzy match against "armor", so the default translation for it is quite off (if indeed fuzzy translations are used at all?).

I'm not quite sure what to do about this one. Re-run msgmerge and alert the translators? Replace "more" with something that either can be translated or doesn't need to be? Get rid of this patch entirely, and get someone to do a "real" fix? (That last one is tempting...but I think most users would prefer a submenu whose branch head said "tanks" to having some cities be unaccessible.)

jason

freeciv@xxxxxxxxxxxxxxxxxxx wrote:
This is an automated notification of a change to freeciv cvs, on Tue Oct 15 02:45:53 PDT 2002 = Tue Oct 15 09:45:53 2002 (GMT)
by Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>

---- Files affected:

freeciv/client/gui-gtk diplodlg.c

---- Log message:

S1_14 BRANCH: In the diplomacy dialog, if there are too many technologies
or cities available to trade the menu will overflow the screen and some
choices will be inaccessible.  This is a kludge fix to manually create
submenus to handle this situation; it assumes a maximum menu item height
of 30 pixels.

Bug reported by Christian Knoke <ChrisK@xxxxxxxx> as PR#771.  Patch by
Christian Knoke, with the expected menu item height changed by me.






[Prev in Thread] Current Thread [Next in Thread]