[Freeciv-Dev] Re: [FreeCiv-Cvs] per: Fix a division by zero that happens
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
|
To: |
freeciv-dev@xxxxxxxxxxx |
|
Subject: |
[Freeciv-Dev] Re: [FreeCiv-Cvs] per: Fix a division by zero that happens if we reque... |
|
From: |
"Per I. Mathisen" <per@xxxxxxxxxxx> |
|
Date: |
Fri, 11 Oct 2002 08:20:53 +0000 (GMT) |
On Thu, 10 Oct 2002, Raimar Falke wrote:
> So IMHO the core dump shouldn't happen. That isn't the expected
> result. Attached is a patch which:
> - adds some asserts
> - makes choose_goal_tech static
> - formatting
> - s/int/bool/
> - some docu
Not sure if you suggested that, but I'm totally opposed to adding this
patch before release. Adding asserts to a problem that is not properly
understood is a recipe for bugs. My fix has the advantage of being
guaranteed not to introduce new bugs, yet avoiding the core dump.
After the release, however, I'm for it.
- Per
|
|
