Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2002:
[Freeciv-Dev] Re: detection of "inline" broken (PR#2104)
Home

[Freeciv-Dev] Re: detection of "inline" broken (PR#2104)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: detection of "inline" broken (PR#2104)
From: Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 29 Sep 2002 19:56:47 -0700 (PDT)

jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
I use Debian Sid.  My system:

+ checking for autoconf >= 2.52 ... found 2.54, ok.
+ checking for automake >= 1.4 ... found 1.5, ok.
+ checking for xgettext >= 0.10.36 ... found 0.11.5, ok.
+ checking for msgfmt >= 0.10.36 ... found 0.11.5, ok.

for some time now I have been unable to compile either GTK or GTK2 clients. I hadn't really looked into it since I figured it was a debian issue, but now I see otherwise.

It happens because config.h contains

  /* Define as `__inline' if that's what the C compiler calls it,
     or to nothing if it is not supported. */
  #define inline

which basically removes the ability to do inlining. This breaks glib, whose header files include some "inline" functions and (the part that I think breaks) some custom code to properly #define "inline".

When I change the above to

  #define inline __inline

compilation works fine.

So the question is: why is inline incorrectly defined?

On a tangential note, these problems would be avoided if we used fc_inline instead of inline. Then there would be no danger of breaking external code.

jason




[Prev in Thread] Current Thread [Next in Thread]