[Freeciv-Dev] gtk2 compiler warnings (PR#2073)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

When I compile gtk2 (and gcc3.2 and the extra -W... flags), I get a 
bunch of warnings.
Patch attached.

At least one of these warnings looks like a temporary thing - i.e. a 
half-finished feature.  Vasco?
jason

Index: client/gui-gtk-2.0/cityrep.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/cityrep.c,v
retrieving revision 1.24
diff -u -r1.24 cityrep.c
--- client/gui-gtk-2.0/cityrep.c        2002/08/10 16:35:12     1.24
+++ client/gui-gtk-2.0/cityrep.c        2002/09/19 20:44:26
@@ -558,8 +558,8 @@
 /****************************************************************
 ...
 *****************************************************************/
-gint cityrep_sort_func(GtkTreeModel *model, GtkTreeIter *a, GtkTreeIter *b,
-                      gpointer data)
+static gint cityrep_sort_func(GtkTreeModel *model,
+                             GtkTreeIter *a, GtkTreeIter *b, gpointer data)
 {
   struct city_report_spec *sp;
   GValue                   value = { 0, };
@@ -1234,7 +1234,7 @@
 /****************************************************************
 ...
 *****************************************************************/
-bool city_building_impr_or_unit(struct city *pcity, cid cid)
+static bool city_building_impr_or_unit(struct city *pcity, cid cid)
 {
   return (cid == cid_encode_from_city(pcity));
 }
Index: client/gui-gtk-2.0/gtkpixcomm.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/gtkpixcomm.c,v
retrieving revision 1.5
diff -u -r1.5 gtkpixcomm.c
--- client/gui-gtk-2.0/gtkpixcomm.c     2002/06/26 03:45:18     1.5
+++ client/gui-gtk-2.0/gtkpixcomm.c     2002/09/19 20:44:26
@@ -40,7 +40,9 @@
 static void gtk_pixcomm_init       (GtkPixcomm *pixcomm);
 static gint gtk_pixcomm_expose     (GtkWidget *widget, GdkEventExpose *event);
 static void gtk_pixcomm_destroy    (GtkObject *object);
+#if 0
 static void build_insensitive_pixbuf (GtkPixcomm *pixcomm);
+#endif
 
 static GtkMiscClass *parent_class;
 
@@ -275,8 +277,10 @@
   }
 }
 
+#if 0
 static void
 build_insensitive_pixbuf(GtkPixcomm *pixcomm)
 {
   /* gdk_pixbuf_composite_color_simple() */
 }
+#endif
Index: client/gui-gtk-2.0/repodlgs.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/repodlgs.c,v
retrieving revision 1.16
diff -u -r1.16 repodlgs.c
--- client/gui-gtk-2.0/repodlgs.c       2002/07/07 21:40:03     1.16
+++ client/gui-gtk-2.0/repodlgs.c       2002/09/19 20:44:27
@@ -686,9 +686,9 @@
   GtkWidget *shell;
 
   switch (response_id) {
-    default:   gtk_widget_destroy(economy_dialog_shell);       return;
     case 1:
-    case 2:
+    case 2:     break;
+    default:   gtk_widget_destroy(economy_dialog_shell);       return;
   }
 
   /* sell obsolete and sell all. */
@@ -970,9 +970,9 @@
   gint       res;
 
   switch (response_id) {
-    default:   gtk_widget_destroy(activeunits_dialog_shell);   return;
+    case 1:     break;
     case 2:    activeunits_report_dialog_update();             return;
-    case 1:
+    default:   gtk_widget_destroy(activeunits_dialog_shell);   return;
   }
 
   /* upgrade command. */
Index: client/gui-gtk-2.0/wldlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/wldlg.c,v
retrieving revision 1.4
diff -u -r1.4 wldlg.c
--- client/gui-gtk-2.0/wldlg.c  2002/04/05 05:56:45     1.4
+++ client/gui-gtk-2.0/wldlg.c  2002/09/19 20:44:28
@@ -304,7 +304,7 @@
   struct worklist_editor *peditor;
   GtkWidget *action_area;
   GtkWidget *button, *scrolled, *dialog_hbox, *hbox, *vbox, *frame;
-  GtkAccelGroup *accel = gtk_accel_group_new();
+  /* GtkAccelGroup *accel = gtk_accel_group_new(); */
 
   static char **wl_clist_titles = NULL;
   char *wl_titles[] = { N_("Type"),