[Freeciv-Dev] [Patch] Various cleanups (PR#2059)

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

The attached patch is the result of some splint messages. Changes:
 - ignore unused return values
 - bool cleanups
 - unreachable code
 - s/if(a)/if(a!=0)/
 - adding static
 - adding missing elements

and I also removed _bv_check_mask_int and cleaned bv_check_mask
up. The old code was unportable (casting from char * to int *) and it
was a premature optimization.

BTW: names starting with "_" are reserved for system libraries.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Two OS engineers facing a petri net chart:
        "dead lock in four moves!"

cleanup1.diff
Description: Text document