Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2002:
[Freeciv-Dev] Re: [Patch] DataIO (PR#1845)
Home

[Freeciv-Dev] Re: [Patch] DataIO (PR#1845)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [Patch] DataIO (PR#1845)
From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Thu, 12 Sep 2002 15:26:07 +0200

On Tue, Sep 10, 2002 at 10:44:06AM -0700, Raimar Falke wrote:
> > 2)
> >   if(unit_type_flag(packet->id, F_PARATROOPERS)) {
> > 
> > instead of that, what about:
> > 
> >   if (BV_ISSET(packet->flags, F_PARATROOPERS)) {
> >  
> > NOTE: If the first is better, than change also the other BV_ISSET that
> > happens afterwords...
> 
> I think that there is no real better-one. I agree that it should be
> consistent.

I didn't found unit_type_flag so this is a non-issue.

New version:
 - moved BV_* and renamed it
 - added some docu

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The two rules for success in life are:
  1) Never tell them everything you know."

Attachment: dataio3.diff.gz
Description: application/gunzip


[Prev in Thread] Current Thread [Next in Thread]