Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2002:
[Freeciv-Dev] Re: switching tilesets at runtime (PR#1930)

[Freeciv-Dev] Re: switching tilesets at runtime (PR#1930)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: switching tilesets at runtime (PR#1930)
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Sat, 17 Aug 2002 00:44:54 -0700 (PDT)

On Fri, 16 Aug 2002, Jason Short wrote:
> > The time has finally come...the client is, IMO, ready for a patch that
> > will switch tilesets at runtime.
> And here is a patch.

Index: client/options.c
RCS file: /home/freeciv/CVS/freeciv/client/options.c,v
retrieving revision 1.65
diff -u -r1.65 options.c
--- client/options.c    2002/08/15 20:24:08     1.65
+++ client/options.c    2002/08/16 18:37:30
@@ -68,28 +68,32 @@
 bool meta_accelerators = TRUE;
 bool map_scrollbars = TRUE;

+static void change_tile_set(struct client_option *o);
+#define GEN_STR_OPTION(name, desc, dflt, cb) { #name, desc, COT_STR, \
                                      NULL, NULL, name, sizeof(name), \
+                                     cb, dflt, NULL }

+static void change_tile_set(struct client_option *o)

+  void (*change_callback) (struct client_option * o);

Style issue: Please use more descriptive names than "dflt", "cb" and "o".

These changes to options.c|h can well be a separate patch. They give a
functionality that I too found that I need for dynamically changing the
sound plugin.


[Prev in Thread] Current Thread [Next in Thread]