[Freeciv-Dev] Corruption Handling (PR#1762)

[nightmare@xxxxxxxxxx]

Full_Name: Davide Pagnin
Version: 1.13.0
Distribution: Don't know
Client: Both (or N/A)
OS: 
Submission from: (NULL) (193.205.82.100)


Adding this issue to the jitterbug database.

Corruption handling procedure city_corruption in the common/city.c file
and the corruption related parameters, need to be rethought to handle
different possibile corruption setting and to be more easy to understand
in their role/work.

Known issues:

1. With a courthouse in a city, it is possible to have more than 50% of 
corruption (this doesn't comply with civ II corruption style)

2. Corruption_level==0 changes the behaviour of the courthouse, but this
cannot be desiderable (imgr-gen take care of this)

3. fixed_distance parameter, is applied before other parameter, that can
modify the output in an undesiderable way

4. there is a capping to the maximum distance for corruption purposes, and
this cap is not modifiable via ruleset parameters

Related problem:

Corruption handling procedure is related to subverting of cities and
bribing of units, perhaps an audit to the code of this function and
putting it in a common procedure can make modify and understanding of
this issues easier.

There is a related patch submitted, but it can be considered a working base
to what has to be done.