[Freeciv-Dev] Re: [FreeCiv-Cvs] per: Change player_has_embassy to return TRUE also i...

[Christian Knoke <chrisk@xxxxxxxx>]

On Sat, Jul 20, 2002 at 05:11:03AM -0700, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> This is an automated notification of a change to freeciv cvs, 
> on Sat Jul 20 05:01:42 PDT 2002 = Sat Jul 20 12:01:42 2002 (GMT)
> by Per I. Mathisen <per@xxxxxxxxxxx>
> 
> ---- Files affected:
> 
> freeciv/common player.c
> 
> ---- Log message:
> 
> Change player_has_embassy to return TRUE also if we check ourselves, 
> to mimic the behaviour of the other treaty check functions and basic 
> sanity. Taken from active ai diplomats patch by me and Gregory.

This patch has some silly consequences which I'm not sure we really want:

in F3 dialog: you can show Intelligence of your own nation
              you can have conference with yourself, but since
              you have no partner to conclude, you have to cancel
              to close the dialog

in F11 dialog: after the rang shown you get the info which nation is best.
               Now, if you are first, your own nation is displayed here,
               repeating the info; confusing

Maybe more.

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.