[Freeciv-Dev] [PATCH] [1.1] Cleanup of those tiny ai/advmilitary.c drones (PR#1756)

[Petr Baudis <pasky@xxxxxxxxxxx>]

Hello,

  so, the curve turned up again after few dead months, and I'm here to annoy
you with my silly cleanups again. This one is something very light, just
tidying up some of the tiny ai/advmilitary.c dwellers. Hopefully nothing
controversial and I believe its life cycle will be short (but usually when I
believe that, you come up nitpicking about everything ;). Behaviour should not
be changed (autogames are hopefully same; the merging failed terribly somewhere
and I can't convience some merged stuff to compile, so I'm going to test that
as soon as I'll solve that ;). Oh, yes, and it seems to me that it compiles.

  The patch is already large enough now, so no, I won't cleanup anything else
there. assess_danger() is itself worth little army of patches with own private
life and religion, another little colony could be built up around
find_something_to_kill(). I've few other half year old cleanups stuck there and
I'm deciding which one to push first, they all cry on me "diff me!", but I
think it'll be either ai_new_spend_gold() (which is not so terrible function,
if you spent few nights with it) or assess_danger() (that one looks _a little_
more friendly, but it has "a little" more complex personality).

  Ah, note that this patch is obviously only seventh in very long line. BTW, I
won't have consistent net access in next few days, so updates may be a bit
dilatory.

  Enjoy your reviewing ;),

-- 
 
                                Petr "Pasky" Baudis
 
* ELinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI occassional hacker
.
You can get much further with a kind word and a gun than you can with a
kind word alone. -- Al Capone
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/

advmilitary-cleanup.diff
Description: Text document