Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2002:
[Freeciv-Dev] Re: [Patch] Merge blink timer callback code (PR#1753) 		Home

[Freeciv-Dev] Re: [Patch] Merge blink timer callback code (PR#1753)

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [Patch] Merge blink timer callback code (PR#1753)
From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Tue, 16 Jul 2002 18:46:44 +0200 
On Tue, Jul 16, 2002 at 11:20:19AM -0500, Mike Kaufman wrote:
> I haven't looked deeply into this, but my first beef is the stupid
> 
> assert(TIMER_INTERVAL == 500);
> 
> much more efficient to simply add a comment at the #define admonishing
> all to NOT CHANGE the variable to anything other than 500.
> 
> otherwise we'll soon be starting to assert everywhere that
> MAX_LEN_USERNAME is 10. (which is much more critical).
> 
> in short: don't assert pointless things...

Ok.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python 2.0 beta 1 is now available [...]. There is a long list of new 
  features since Python 1.6, released earlier today. We don't plan on 
  any new releases in the next 24 hours."
    -- Jeremy Hylton at Slashdot
[Prev in Thread] Current Thread [Next in Thread]