[Freeciv-Dev] Re: Compaq Tru64 Unix Alpha platform - Building freeciv

[Davide Pagnin <nightmare@xxxxxxxxxx>]

On Mon, 2002-06-10 at 10:18, Raimar Falke wrote:
> On Sun, May 19, 2002 at 01:43:54AM +0200, Davide Pagnin wrote:
> > Problems with char subscript:
> > common/capability.c:44: warning: subscript has type `char'
> > common/capability.c:44: warning: subscript has type `char'
> > common/capability.c:75: warning: subscript has type `char'
> > common/capability.c:75: warning: subscript has type `char'
> > common/inputfile.c:341: warning: subscript has type `char'
> > common/inputfile.c:358: warning: subscript has type `char'
> > common/inputfile.c:646: warning: subscript has type `char'
> > common/inputfile.c:652: warning: subscript has type `char'
> > common/inputfile.c:655: warning: subscript has type `char'
> > common/inputfile.c:682: warning: subscript has type `char'
> > common/inputfile.c:709: warning: subscript has type `char'
> > common/inputfile.c:756: warning: subscript has type `char'
> > common/inputfile.c:762: warning: subscript has type `char'
> > common/inputfile.c:765: warning: subscript has type `char'
> > common/inputfile.c:769: warning: subscript has type `char'
> > common/inputfile.c:789: warning: subscript has type `char'
> > common/registry.c:613: warning: subscript has type `char'
> > common/registry.c:614: warning: subscript has type `char'
> > common/registry.c:619: warning: subscript has type `char'
> > common/shared.c:439: warning: subscript has type `char'
> > common/shared.c:476: warning: subscript has type `char'
> > common/shared.c:540: warning: subscript has type `char'
> > common/shared.c:550: warning: subscript has type `char'
> > server/stdinhand.c:1921: warning: subscript has type `char'
> > server/stdinhand.c:2054: warning: subscript has type `char'
> > server/stdinhand.c:2059: warning: subscript has type `char'
> > server/stdinhand.c:2099: warning: subscript has type `char'
> > server/stdinhand.c:2105: warning: subscript has type `char'
> > server/stdinhand.c:2379: warning: subscript has type `char'
> > server/stdinhand.c:2382: warning: subscript has type `char'
> > server/stdinhand.c:2542: warning: subscript has type `char'
> > server/stdinhand.c:2545: warning: subscript has type `char'
> > server/stdinhand.c:2648: warning: subscript has type `char'
> > server/stdinhand.c:2656: warning: subscript has type `char'
> > server/stdinhand.c:2664: warning: subscript has type `char'
> > server/stdinhand.c:2888: warning: subscript has type `char'
> > server/stdinhand.c:2899: warning: subscript has type `char'
> > server/stdinhand.c:2908: warning: subscript has type `char'
> > server/stdinhand.c:2932: warning: subscript has type `char'
> > server/stdinhand.c:2944: warning: subscript has type `char'
> > server/stdinhand.c:3680: warning: subscript has type `char'
> > server/stdinhand.c:3687: warning: subscript has type `char'
> > server/stdinhand.c:3692: warning: subscript has type `char'
> > server/stdinhand.c:3712: warning: subscript has type `char'
> > server/stdinhand.c:3741: warning: subscript has type `char'
> > client/clinet.c:498: warning: subscript has type `char'
> > client/options.c:313: warning: subscript has type `char'
> > client/tilespec.c:495: warning: subscript has type `char'
> > client/tilespec.c:496: warning: subscript has type `char'
> > client/tilespec.c:497: warning: subscript has type `char'
> > client/gui-gtk/dialogs.c:2242: warning: subscript has type `char'
> > client/gui-xaw:dialogs.c:2370: warning: subscript has type `char'
> 
> Can you try the attached patch?

I've tried the attached patch, but some warning are left, in particular
I've noticed that all the is* family function is not wrapped to the
my_is* family function in the server/stdinhand.c file.
I've modified your patch, and wrapped them with the my_is* functions.
With the modified patch, the warning count is reduced to 5!

srv_main.c:924: warning: subscript has type `char'
options.c:313: warning: subscript has type `char'
tilespec.c:495: warning: subscript has type `char'
tilespec.c:496: warning: subscript has type `char'
tilespec.c:497: warning: subscript has type `char'

(call to toupper and tolower, perhaps also the to* family needs a my_to*
wrapper?)

        Ciao, Davide

> 
>       Raimar
> 
> -- 
>  email: rf13@xxxxxxxxxxxxxxxxx
>  "I do feel kind of sorry for Microsoft. Their attornies and marketing
>   force must have tons of ulcers trying to figure out how to beat (not
>   just co-exist with) a product that has no clearly defined (read
>   suable) human owner, and that changes on an hourly basis like the
>   sea changes the layout of the sand on a beach. Severely tough to
>   fight something like that."
>     -- David D.W. Downey at linux-kernel

ctype2.patch
Description: Text Data