[Freeciv-Dev] Re: CMA attributes - gcc optimization problem with Tru64 Unix

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Fri, Jun 07, 2002 at 12:41:29PM +0200, Davide Pagnin wrote:
>       Hi All!
> 
> I've applied the patch from Raimar, with a little correction:
> assert(pvalue); --> assert(pvalue!=NULL);
> to stop the gcc complaining of the bad cast from pointer to int
> 
> I attach the results, of both the optimized and no-optimized civclient.
> (In this case the output is generated without --debug=3 option,
> I've seen that Raimar code, don't use LOG_VERBOSE.
> 
>       Davide

> 2: attribute_get(key=100000001, id=117, x=-1, y=-1, max_data_length=36, 
> data=11fffb560)
> 2:   not found
> 2:   [0], key=(key=100000001, id=117, x=-1, y=-1) value_len=36

This is the problem. This suggests that attr_hash_val_fn or
attr_hash_cmp_fn is corrupt.

Can you please send me the good and the bad attribute.s (build from a
clean attribute.c). You can do this using:
$ cd client
$ gcc -DHAVE_CONFIG_H -I. -I.. -I./include -I../common -I../intl -I./agents -S 
-c attribute.c

and the same with -O2.

Can you also please apply the attached patch and send me the bad output?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Life is too short for reboots."

64bit_attr_test2.diff
Description: Text document