[Freeciv-Dev] Re: metaserver join bug (PR#1420)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Apr 30, 2002 at 09:21:17AM -0700, Per I. Mathisen wrote:
> After joining a metaserver devel game on alkar.net with latest cvs client,
> I get this error, which I don't understand:
> 
> civclient: packhand.c:2339: handle_processing_finished: Assertion
> `aconnection.client.request_id_of_currently_handled_packet != 0' failed.

The server send a PACKET_PROCESSING_FINISHED before a
PACKET_PROCESSING_STARTED is sent. At least so the client
thinks. Problem is that client idea of PACKET_PROCESSING_STARTED is
different than the servers idea of PACKET_PROCESSING_STARTED. Because
of this:

$ cvs diff -u -r 1.112 -r 1.113 common/packets.h |less
Index: common/packets.h
===================================================================
RCS file: /home/freeciv/CVS/freeciv/common/packets.h,v
retrieving revision 1.112
retrieving revision 1.113
diff -u -r1.112 -r1.113
--- common/packets.h    2002/03/21 20:35:29     1.112
+++ common/packets.h    2002/04/05 05:56:49     1.113
@@ -59,7 +59,6 @@
   PACKET_PLAYER_REVOLUTION,
   PACKET_PLAYER_GOVERNMENT,
   PACKET_PLAYER_RESEARCH,
-  PACKET_PLAYER_WORKLIST,
   PACKET_UNIT_BUILD_CITY,
   PACKET_UNIT_DISBAND,
   PACKET_REMOVE_UNIT,
...

revision 1.113
date: 2002/04/05 05:56:49;  author: kauf;  state: Exp;  lines: +0 -4
remove global worklists from the server and savegames.
global worklists are now maintained client-side.

Patch by Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>

But it is also my fault that I didn't spot this.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I haven't lost my mind - it's backed up on tape somewhere."