Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2002:
[Freeciv-Dev] Re: [Patch] ai_calc_*
Home

[Freeciv-Dev] Re: [Patch] ai_calc_*

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx, freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [Patch] ai_calc_*
From: Raahul Kumar <raahul_da_man@xxxxxxxxx>
Date: Tue, 5 Mar 2002 16:19:37 -0800 (PST)

--- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> The attached patch does:
>  - pass the map posistion to the ai_calc_* functions. This allows us
>  to remove the city_map_to_map call
>  - rename i,j to cx,cy
>  - initialize variables to remove a few lines
>  - change city_map_iterate to city_map_checked_iterate
> 

The patch is fine. I was just wondering if I could convince you to get rid
of that annoying variable m. Perhaps some additional comemnts in the block
headers
would be nice.

__________________________________________________
Do You Yahoo!?
Try FREE Yahoo! Mail - the world's greatest free email!
http://mail.yahoo.com/


[Prev in Thread] Current Thread [Next in Thread]