[Freeciv-Dev] Re: [PATCH] [1.5] move some common AI equations to kill_desire() (PR#1279)

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

I believe I said it already and I am not afraid to repeat: this patch is 
useful and done well and I see absolutely no reason to delay it's 
inclusion.  Moreover, it would simplify my "flying AI" patch which I will 
hopefully release soon.

If, however, Petr is forced to changed his patch, I'd recommend a 
correction to the comment of kill_desire (that's a very Buddhist name, 
"kill your desires").  It is benefit which is counted in shields, the 
result of the function is NOT in shields, it's in some "universal" points 
(that's why we multiply by SHIELD_WEIGHTING).

On Thu, 28 Feb 2002, Petr Baudis wrote:

> Just a reminder - what's up with the patch, please? :)
> 
> Updated patch attached - I rediffed against current CVS - only line number
> changes, but in order to remove all possible excuses for you ... ;)))
> 
> Have a nice day,