[Freeciv-Dev] Re: [PATCH] gtk/gui_main cleanup (PR#1245)

[Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>]

On Sun, Jan 27, 2002 at 10:57:04PM +0000, Vasco Alexandre Da Silva Costa wrote:
> On Sun, 27 Jan 2002, Mike Kaufman wrote:
> 
> > here is a patch that cleans up gui_main
> > 
> > reasons to to this:
> > o there were a lot of variables declared that either don't do anything 
> >   anymore or are redundant.
> > o other cruft.
> > o the formatting was so bad that it offended my sensibilities.
> > o it was pretty much unreadable.
> > o a couple of people indicated that they wanted to see civworld in the
> >   tree sooner rather than later, so I had a semi-brilliant idea about how
> >   to do this with only a bit of pain. The cleanup reduces the impact of
> >   civworld inclusion, by reducing the number of #ifdefs needed.
> >   functions got moved around to facilitate this. (the original intention)
> > 
> > anyhow, unless somebody yells (vasc?) this is goin' in toot-sweet.
> 
> Heh, blame me for the formating. I was programming in GTK+ at the time,
> and i tend to use the style the original authors use when programming.
> That style is basically the GTK+ library source code style (GNUish) except
> for the GNU brace style, which i despise dearly.
> When i started the GTK+ client i didn't know i was going to finish it
> anyway, so i didn't care for it much. I did ask if i should reformat
> everything before commiting at the time, but the administrators thought it
> was better that i commited anyway and it would be changed in due time.
> 
> Anyway, i don't care about it. Reformat it at will. I notice you added
> some functions to change the way the unit stack is shown, no beef there
> either.

Hey!, no that wasn't me...

----------------------------
revision 1.67
date: 2000/07/10 06:31:22;  author: dwp;  state: Exp;  lines: +50 -4
Make update_unit_pix_label() gui-independent, using two new gui-dependent
functions set_unit_icon() and set_unit_icons_more_arrow().
----------------------------

I assume at least this is what you're talking about...otherwise some
weird stuff got into the patch. when was the last time you looked at
this code? :)

I'll commit this pretty soon then...

-mike

> 
> ---
> Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa
> 
>