[Freeciv-Dev] Re: [PATCH] more complete fix for PR#1214

[Jason Short <vze2zq63@xxxxxxxxxxx>]

Mike Kaufman wrote:

> On Thu, Jan 17, 2002 at 01:46:55AM -0500, Jason Short wrote:
>
> > Mike Kaufman wrote:
> >
> >
> > > I almost commited this along with Jason's patch, but I thought that I
> > > might see if you all can find something wrong with it first.
> > >         
> > > in a nutshell, if you have a savefile with just the map and some start
> > > positions, it is (and should be) a perfectly valid savefile (it's a
> > > new_game). But you get scary messages when you shouldn't.
> > Such a game cannot be produced by civserver, right?  It can only be made 
> >  by civserver (I assume) or manually?
>        ^^^^^^^^
>      civworld, I assume...
Doh!  Yes, I meant civworld.


> > If this is the case, some comment to that effect is needed, lest someone 
> > try to remove the "unneeded" check later.
> which check is this that you're talking about?

You check for game.is_new_game.  Is it possible to save such games from 
within FreeCiv?  AFAICT no.  This is a "special case" to allow loading 
of scenarios, right?
Either way, I think it'd be better commented - so that people like me 
won't get confused :-).
jason