Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2002:
[Freeciv-Dev] Re: [PATCH] more complete fix for PR#1214
Home

[Freeciv-Dev] Re: [PATCH] more complete fix for PR#1214

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Cc: Freeciv-Dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [PATCH] more complete fix for PR#1214
From: Jason Short <vze2zq63@xxxxxxxxxxx>
Date: Thu, 17 Jan 2002 03:15:41 -0500
Reply-to: jdorje@xxxxxxxxxxxx

Mike Kaufman wrote:

On Thu, Jan 17, 2002 at 01:46:55AM -0500, Jason Short wrote:

Mike Kaufman wrote:


I almost commited this along with Jason's patch, but I thought that I
might see if you all can find something wrong with it first.
in a nutshell, if you have a savefile with just the map and some start
positions, it is (and should be) a perfectly valid savefile (it's a
new_game). But you get scary messages when you shouldn't.

Such a game cannot be produced by civserver, right? It can only be made by civserver (I assume) or manually?

       ^^^^^^^^
     civworld, I assume...

Doh!  Yes, I meant civworld.


If this is the case, some comment to that effect is needed, lest someone try to remove the "unneeded" check later.


which check is this that you're talking about?


You check for game.is_new_game. Is it possible to save such games from within FreeCiv? AFAICT no. This is a "special case" to allow loading of scenarios, right?

Either way, I think it'd be better commented - so that people like me won't get confused :-).

jason



[Prev in Thread] Current Thread [Next in Thread]